Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autolink plugin typing support #1815

Closed
jacekbogdanski opened this issue Mar 19, 2018 · 5 comments
Closed

Autolink plugin typing support #1815

jacekbogdanski opened this issue Mar 19, 2018 · 5 comments
Assignees
Labels
plugin:autolink The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone

Comments

@jacekbogdanski
Copy link
Member

jacekbogdanski commented Mar 19, 2018

Are you reporting a feature request or a bug?

Feature request

Autolink plugin currently only works for pasted content. We could expand the plugin to handle turning URLs and emails into links when typing text into editor.

Provide detailed reproduction steps (if any)

  1. Open CKEditor sample with enabled autolink plugin.
  2. Type http://example.com

Expected result

URL has been replaced with HTML link e.g. <a href=“http://example.com”>http://example.com</a>.

Actual result

URL has been typed as a normal text.

@jacekbogdanski jacekbogdanski added status:confirmed An issue confirmed by the development team. plugin:autolink The plugin which probably causes the issue. labels Mar 19, 2018
@mlewand mlewand added type:feature A feature request. target:major Any docs related issue that should be merged into a major branch. labels Mar 19, 2018
@ghost
Copy link

ghost commented Jun 6, 2018

are you guys planning to do this feature?

@mlewand
Copy link
Contributor

mlewand commented Jun 12, 2018

@hkakumanu-ttc it's not yet in our backlog - however the best way to show that you'd like to see it in the release is to add 👍 reaction in the first post.

@mlewand mlewand added this to the Backlog milestone Jun 25, 2018
@jacekbogdanski jacekbogdanski self-assigned this Jul 15, 2018
@Comandeer Comandeer modified the milestones: Backlog, 4.11.0 Jul 18, 2018
@Comandeer
Copy link
Member

Autolinking was merged to major and will appear in CKEditor 4.11.0.

@mlewand
Copy link
Contributor

mlewand commented Jul 20, 2018

The feature landed on a major branch, however autolink plugin is not by default included in any of our presets, thus it's not included in any sample.

I created a codepen demo where it could be previewed: https://codepen.io/mlewand/pen/QBGYpL

@mlewand
Copy link
Contributor

mlewand commented Jul 20, 2018

BTW guys, I'm wondering if there should be added a simplified regexp for string like www.example.example, because for URLs currently one must write a fully qualified URL including a protocol, which is a rather rare case. @jacekbogdanski @Comandeer

Also I have found an bug described in #2244.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:autolink The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Development

No branches or pull requests

3 participants