Keep CKEditor and plugins up to date.

[klonos]

This is a sibling to #2493

Keeping the editor up to date regularly should minimise troubleshooting issues introduced along the way (because we'll be "jumping" less versions up).

List of things to test each time we update:

• uploading an image via form field in modal
• uploading an image via drag & drop into rich-text area
• uploading an image via copy/paste into rich-text area
• align image + caption right and left with P alignment buttons
• link to existing content via link dialog
• link to file upload via link dialog
• more??

---

PR by @klonos (4.7.3 to 4.11.1): backdrop/backdrop#2361 Merged into 1.12.0
PR by @quicksketch (4.11.1 to 4.12.1) backdrop/backdrop#2881
PR by @quicksketch (4.12.1 to 4.14.0) backdrop/backdrop#3103

[klonos]

...we are currently using version 4.7.3 (backdrop/backdrop#2134), which was a security update.

[klonos]

PR up for review: backdrop/backdrop#2347

Note that the build has automatically added core/misc/ckeditor/plugins/clipboard.

Changelog: https://github.com/backdrop/backdrop/blob/4fb82d1aef7e6459d59e2e71fa8fc6e0bfcdf005/core/misc/ckeditor/CHANGES.md

[klonos]

New PR to update to 4.11.0: backdrop/backdrop#2361

Notable changes since 4.10.1:

• #2062: Added the emoji dropdown that allows the user to choose the emoji from the toolbar and search for them using keywords.
• #2154: The Link plugin now supports phone number links.
• #1815: The Auto Link plugin supports typing link completion.
• #651: Text pasted using the Paste from Word plugin preserves indentation in paragraphs.
• #1176: The Balloon Panel can now be attached to a selection instead of an element.

[herbdool]

I tested image embedding, linking to existing content and file embedding in backdrop/backdrop#2361. All works well for me.

[klonos]

Thanks @herbdool 👍 ...ideally, I would like us to have a way to get this update out to people that wish to help with testing, and in fact get such changes (CKEditor, jQuery, jQuery UI etc.) out as early as possible to give them enough time to be beta-tested. I realise that people using git as part of their deployments can checkout the branch, but it would help to have a packaged dev version, or even RCs. A subject for the next meeting to be discussed I guess.

[klonos]

PR updated to upgrade to 4.11.1 ...plus also updated the CKEDITOR_VERSION constant as per your comment in the PR @quicksketch (sorry I missed that 😅).

[quicksketch]

I've merged backdrop/backdrop#2361 into 1.x for 1.12.0. The 3 week lead time before the Jan 15 is less than we wanted, and that's my fault for dallying the merge of this PR. Please keep an eye out for any problems with the CKEditor update so we can correct them before the 1.12 release. Thanks @klonos and @herbdool!

I'm not sure if I should close this issue or keep it open to bump to the next version. Thoughts?

[klonos]

Thanks @quicksketch 👍

...as also mentioned during the dev meeting, we should encourage all people that have open PRs to close and reopen them, so that the sandboxes get rebuilt with the updated version of CKEditor. We should do that at the very least for any CKEditor-related issues, because it would "grab" a bigger set of testers, and thus help catch any possible breakages sooner. (I'll cross-post this on Gitter 😉)

I think leave this ticket open and bump to 1.13.

[klonos]

RTBC 👍

[quicksketch]

Great, merged backdrop/backdrop#2881. We're now up to 4.12.1. 😄

[jenlampton]

My RTBC here is for this pr: backdrop/backdrop#3103 which brings CKE up to 4.14.0

[quicksketch]

We're now on the current version, CKEditor 4.14.0.

[klonos]

Well, necessity causes things to get done 😅 ...after the recent 1.19.1 security update, we're now in the most recent v4.16.1:

• SA-BACKDROP-CORE-2021-003 by securitylight, xjm, greggles, larowlan, … backdrop#3636
• SA-BACKDROP-CORE-2021-003 by securitylight, xjm, greggles, larowlan, … backdrop#3637

[quicksketch]

backdrop/backdrop#3684 updates us to 4.16.2.