Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs do not handle timezones correctly #102

Closed
ThrawnCA opened this issue Mar 4, 2020 · 3 comments
Closed

Logs do not handle timezones correctly #102

ThrawnCA opened this issue Mar 4, 2020 · 3 comments

Comments

@ThrawnCA
Copy link
Collaborator

ThrawnCA commented Mar 4, 2020

XLoader logs are generated without specifying a timezone, but then displayed in the web UI as if the timestamps were UTC. This can result in absurd output like -1 day ago.
ThrawnCA referenced this issue in qld-gov-au/ckanext-xloader Apr 24, 2020
@ThrawnCA
add time zone data to XLoader logs if not present, #102
ea1decc 
- otherwise they'll be displayed as if they were GMT, but they were probably not generated that way
@Chealer
Copy link

Chealer commented Apr 24, 2020

We're also seeing log messages about errors from "4 hours ago", which are about errors that just occurred, as we're in UTC-4, so I guess that confirms the problem.

@ThrawnCA
Copy link
Collaborator Author

@Chealer If nothing happens here, we'll probably cut a release of https://github.com/qld-gov-au/ckanext-xloader soon with this patched.

@ThrawnCA ThrawnCA mentioned this issue Apr 29, 2020
Open
duttonw referenced this issue in qld-gov-au/ckanext-xloader Jul 9, 2020
@ThrawnCA @duttonw
add time zone data to XLoader logs if not present, #102
9796833 
- otherwise they'll be displayed as if they were GMT, but they were probably not generated that way
@ThrawnCA
Copy link
Collaborator Author

Fixed as part of #166

JVickery-TBS pushed a commit to JVickery-TBS/ckanext-xloader that referenced this issue Jul 23, 2024
@ThrawnCA
Merge pull request ckan#102 from qld-gov-au/snyk-fix-705136bc5e6de16a…
ac9d2bf 
…771577aa8dcf9ec4

[Snyk] Fix for 2 vulnerabilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Chealer @ThrawnCA