generally improve formatting of resource item metadata #6356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pdelboca Please let me know if I can do anything to improve this or if you need me to clarify things. |
|
No need @paulmueller ! Looks good to me! Sorry for the delay in reviewing this :) cc @amercader |
|
🌷 @amercader please merge |
|
Thanks for this @paulmueller and sorry it took so long to be merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6350 and improves handling of numbers in general.
Proposed fixes:
Initially I thought that the issue described in #6350 only affects
Falsebooleans, but it also affects all numbers that are 0 (integer and float). This PR makesckan.lib.helpers.format_resource_itemsproperly format (as in format as a string) numbers. Previously, booleans and zero-valued numbers were not converted to a string. I added a parametrized test function.Features:
Please [X] all the boxes above that apply