-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include icon for image data #3048
Conversation
In #2910 @amercader pointed out that the original files seem to be in this repository: https://github.com/mintcanary/file-types |
@amercader I think we should merge this rather soon instead of waiting for the original vector files. Waiting for them led to the last PR becoming conflicting with the current master. I could create a separate issue for also including the vector files? |
@k-nut : i think to add the vector files in the repo won't be the best idea (may these should be in a other/single one) |
Yes. We might want to store them in a separate repo. But at least having something like a link to the original somewhere in the ckan project could prove useful already. |
okay i'll add the source . you can move them to a custom path afterwards |
please take a look here: https://drive.eccenca.com/d/73541a96f2/ |
@hknochi cool, thank you! How are the icons licensed? |
@amercader do you think we should create a new repository for design assets like this? Or is there something already where we could put this? Or would you just include it in this repository? |
Fromm eccenca's POV this should not be decided by us but by @smth who originally pushed these files (mintcanary/file-types@1740cd6). The work of @hknochi can be licensed under any terms suitable for you. |
I just added a license here. |
Created a first pull request in the new |
Fixes #2948, #2910
Proposed fixes:
In order to clean up Pull Requests a little I just took the changes from #2948 and applied the to the lastest master. Of course this still does not include the original vector files as I do no have them.
Features: