Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activity stream actions not overridable #4684

Open
amercader opened this issue Mar 14, 2019 · 1 comment
Open

Activity stream actions not overridable #4684

amercader opened this issue Mar 14, 2019 · 1 comment
Assignees
@amercader

Comments

@amercader
Copy link
Member

Some calls to action functions in action/get.py call the functions directly instead of using get_action, meaning they can't be overridden from extensions.
@amercader amercader self-assigned this Mar 14, 2019
@amercader
Copy link
Member Author

Just noticed that after #4627 this is no longer relevant in master. I'll target 2.8 for this.

amercader added a commit that referenced this issue Mar 14, 2019
@amercader
[#4684] Use get_action to call activity actions
093d44e 
Otherwise they can not be overridden
@amercader amercader mentioned this issue Mar 14, 2019
Merged
wardi added a commit that referenced this issue Mar 14, 2019
@wardi
Merge pull request #4685 from ckan/4684-use-get_action-in-activity-ac…
809d1ee 
…tions

[#4684] Use get_action to call activity actions
smotornyuk pushed a commit that referenced this issue Jun 16, 2019
@amercader @smotornyuk
[#4684] Use get_action to call activity actions
25ed4b5 
Otherwise they can not be overridden
amercader added a commit that referenced this issue Sep 4, 2019
@amercader
[#4684] [#4684] Add missing get_action calls
b1129cf
amercader pushed a commit that referenced this issue Sep 4, 2019
@amercader
[#4684] Fix circleci error: E: Unable to locate package openjdk-8-jdk
b6c14ae 
This occurred because the docker/python:2 image switched from Debian stretch to buster this week.
Buster uses openjdk 11 instead of 8, but even with this CKAN was unable
to talk to Solr - maybe to do with AppArmor enabled in Buster. It was
just easiest to pin back to stretch.
wardi added a commit that referenced this issue Sep 5, 2019
@wardi
Merge pull request #4967 from ckan/4684-use-get_action-in-activity-ac…
d3f42c8 
…tions-2

[#4684] Add missing get_action calls
smotornyuk pushed a commit that referenced this issue Mar 24, 2020
@amercader @smotornyuk
[#4684] [#4684] Add missing get_action calls
a626f10
smotornyuk pushed a commit that referenced this issue Mar 24, 2020
@smotornyuk
[#4684] Fix circleci error: E: Unable to locate package openjdk-8-jdk
d2a4f35 
This occurred because the docker/python:2 image switched from Debian stretch to buster this week.
Buster uses openjdk 11 instead of 8, but even with this CKAN was unable
to talk to Solr - maybe to do with AppArmor enabled in Buster. It was
just easiest to pin back to stretch.
smotornyuk pushed a commit that referenced this issue Mar 24, 2020
@amercader @smotornyuk
[#4684] [#4684] Add missing get_action calls
6dbdb45
smotornyuk pushed a commit that referenced this issue Mar 24, 2020
@smotornyuk
[#4684] Fix circleci error: E: Unable to locate package openjdk-8-jdk
2921c63 
This occurred because the docker/python:2 image switched from Debian stretch to buster this week.
Buster uses openjdk 11 instead of 8, but even with this CKAN was unable
to talk to Solr - maybe to do with AppArmor enabled in Buster. It was
just easiest to pin back to stretch.
smotornyuk pushed a commit that referenced this issue Mar 25, 2020
@amercader @smotornyuk
[#4684] [#4684] Add missing get_action calls
002aab2
fostermh pushed a commit to cioos-siooc/ckan that referenced this issue Sep 10, 2021
@fostermh
[ckan#4684] Fix circleci error: E: Unable to locate package openjdk-8…
e35b8d0 
…-jdk

This occurred because the docker/python:2 image switched from Debian stretch to buster this week.
Buster uses openjdk 11 instead of 8, but even with this CKAN was unable
to talk to Solr - maybe to do with AppArmor enabled in Buster. It was
just easiest to pin back to stretch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amercader amercader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amercader