Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check dbs if ENV variables are not defined #34

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Do not check dbs if ENV variables are not defined #34

merged 2 commits into from
Oct 24, 2023

Conversation

pdelboca
Copy link
Member

@pdelboca pdelboca commented Oct 23, 2023 •
edited
Loading

We are still checking for the connection even when the ENV variables are not defined.

This causes some confusing logs since we are saying that we are not checking but "something" is being checked anyways.

[prerun] Plugins set.
[prerun] CKAN_DATASTORE_WRITE_URL not defined, not checking db
connection to server on socket "/run/postgresql/.s.PGSQL.5432" failed: No such file or directory
	Is the server running locally and accepting connections on that socket?

[prerun] Unable to connect to the database, waiting...
connection to server on socket "/run/postgresql/.s.PGSQL.5432" failed: No such file or directory
	Is the server running locally and accepting connections on that socket?

[prerun] Unable to connect to the database, waiting...
connection to server on socket "/run/postgresql/.s.PGSQL.5432" failed: No such file or directory
	Is the server running locally and accepting connections on that socket?

[prerun] Unable to connect to the database, waiting...
connection to server on socket "/run/postgresql/.s.PGSQL.5432" failed: No such file or directory
	Is the server running locally and accepting connections on that socket?

[prerun] Unable to connect to the database, waiting...
connection to server on socket "/run/postgresql/.s.PGSQL.5432" failed: No such file or directory
	Is the server running locally and accepting connections on that socket?

[prerun] Unable to connect to the database, waiting...
[prerun] Giving up after 5 tries...

@pdelboca pdelboca requested a review from kowh-ai October 23, 2023 09:24
kowh-ai
kowh-ai requested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@kowh-ai kowh-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pdelboca - Are you able to update the 2.9 prerun.py file too?

@pdelboca
Copy link
Member Author

Done @kowh-ai !

@kowh-ai kowh-ai merged commit f5b8eef into main Oct 24, 2023
@themowski themowski mentioned this pull request Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kowh-ai kowh-ai kowh-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdelboca @kowh-ai