-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tomlkit along with associated deps #760
Conversation
Thanks a lot for the quick PR @jstaph! |
@jstaph maybe we should raise an issue to https://github.com/pradyunsg/furo ? I can have a look next week. |
I'm not certain it's a problem upstream, TBH. I haven't used furo myself, and would need to dig a little deeper into what's causing the error. I personally won't be able to look into it for a couple of weeks. |
pyproject.toml
Outdated
packaging = ">=20.9" | ||
html5lib = "^1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why html5lib
was needed to be added to simply unpin tomlkit
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legit question, and I'm not certain. IIRC, I did some experimentation to try to sort out what was happening with furo, and this might be related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in 0c102ab
@cjolowicz Could this be merged? The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@cjolowicz When this is merged, would you be able to publish a new release with it included? ❤️ |
fixes #755
Removed upper bound on tomlkit, and accepted the following associated updates:
certifi (2021.10.8 -> 2022.5.18.1)
filelock (3.7.0 -> 3.7.1)
msgpack (1.0.3 -> 1.0.4)
ruamel.yaml.clib (0.2.6)
identify (2.5.0 -> 2.5.1)
ruamel.yaml (0.17.17 -> 0.17.21)
furo (2022.4.7 -> 2022.6.4)
mypy (0.950 -> 0.960)
pep8-naming (0.12.1 -> 0.13.0)
Please let me know if this isn't desirable; I'm happy to iterate.