WIP: Automerge workflow #401
Conversation
|
@cjolowicz I recreated my PRs with much less commits. I had to delete my fork since master was compromised and rebase from upstream wasn't working (I still struggle with rebases and remotes). |
|
@cjolowicz LGTM? I really find useful having dependabot PRs automatically merged =p |
|
Sorry for letting this sit here for so long. I must confess, I have doubts that this is a good fit for this template. It's no doubt very useful in many projects, but it makes strong assumptions about the way a project "ticks". You need to have a very thorough test suite to prevent upgrades that break your code. Even then, there is no guarantee nothing will break. And for some projects, merging PRs without review is a no-no, even for Dependabot. Also I'm curious, I didn't understand if/how the workflow prevents merging when other checks failed? |
|
@cjolowicz you are right, I got my first automerged broken lib (staticdev/irpf-cei@0d0dd50) I will put this on draft until I make safer automerge passing all checks. Since GA does not support natively dependency between workflows, I found a workaround using GitHub Workflow API in this repo where Publish workflow depends on CI workflow. |
|
Thanks for working on this @staticdev I'm closing this for the reasons mentioned above. Please feel free to continue the discussion though. |
Closes #296