Prevent modifications to input data during array checks. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assert_2d_sort function was modifying its inputs during the sort call. We should make this sort happen on a copy of the data so we don't produce side effects.
|
Wow that's a nasty bug that would cause some hair to be pulled out. This LGTM! Thanks! |
cjekel
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_2d_sort function was modifying its inputs during the sort call. We should make this sort happen on a copy of the data so we don't produce side effects.
It turns out that numpy.array.reshape sometimes produces a view and is not guaranteed to make a copy, hence the need to create an explicit copy prior to sorting.