Re-enable the indexPattern:placeholder setting. Change its value to b…

…e an empty string. (elastic#20685)
cjcenizal · Jul 13, 2018 · f73143c · f73143c
1 parent 99e697d
commit f73143c
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/...a/public/management/sections/indices/create_index_pattern_wizard/__tests__/render.test.js b/...a/public/management/sections/indices/create_index_pattern_wizard/__tests__/render.test.js
@@ -22,6 +22,12 @@ const unmountComponentAtNode = jest.fn();
 
 jest.doMock('react-dom', () => ({ render, unmountComponentAtNode }));
 
+jest.mock('ui/chrome', () => ({
+  getUiSettingsClient: () => ({
+    get: () => '',
+  }),
+}));
+
 const { renderCreateIndexPatternWizard, destroyCreateIndexPatternWizard } = require('../render');
 
 describe('CreateIndexPatternWizardRender', () => {

diff --git a/...e_index_pattern_wizard/components/step_index_pattern/__tests__/step_index_pattern.test.js b/...e_index_pattern_wizard/components/step_index_pattern/__tests__/step_index_pattern.test.js
@@ -24,6 +24,13 @@ import { StepIndexPattern } from '../step_index_pattern';
 jest.mock('../../../lib/ensure_minimum_time', () => ({
   ensureMinimumTime: async (promises) => Array.isArray(promises) ? await Promise.all(promises) : await promises
 }));
+
+jest.mock('ui/chrome', () => ({
+  getUiSettingsClient: () => ({
+    get: () => '',
+  }),
+}));
+
 jest.mock('../../../lib/get_indices', () => ({
   getIndices: (service, query) => {
     if (query.startsWith('e')) {

diff --git a/...s/indices/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.js b/...s/indices/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.js
@@ -38,6 +38,10 @@ import {
   EuiCallOut,
 } from '@elastic/eui';
 
+import chrome from 'ui/chrome';
+
+const uiSettings = chrome.getUiSettingsClient();
+
 export class StepIndexPattern extends Component {
   static propTypes = {
     allIndices: PropTypes.array.isRequired,
@@ -49,7 +53,7 @@ export class StepIndexPattern extends Component {
   }
 
   static defaultProps = {
-    initialQuery: '',
+    initialQuery: uiSettings.get('indexPattern:placeholder'),
   }
 
   constructor(props) {

diff --git a/src/core_plugins/kibana/ui_setting_defaults.js b/src/core_plugins/kibana/ui_setting_defaults.js
@@ -487,8 +487,8 @@ export function getUiSettingDefaults() {
     },
     'indexPattern:placeholder': {
       name: 'Index pattern placeholder',
-      value: 'logstash-*',
-      description: `The placeholder for the field "Index name or pattern" in the "Settings > Indices" tab.`,
+      value: '',
+      description: `The placeholder for the "Index pattern name" field in "Management > Index Patterns > Create Index Pattern".`,
     },
     'context:defaultSize': {
       name: 'Context size',