This repository has been archived by the owner on Aug 29, 2020. It is now read-only.
Adds battery support #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up mod file; adds flag for battery. Adds documentation; fixes missing color sets for battery.
cjbassi
suggested changes
Dec 29, 2018
main.go
Outdated
| @@ -212,6 +236,10 @@ func initWidgets() { | |||
| wg.Done() | |||
| }() | |||
| if !minimal { | |||
| go func() { | |||
There was a problem hiding this comment.
I think we should change this so that the battery is only created if the battery flag is set. The widget count variable also has to be changed to account for this.
There was a problem hiding this comment.
:sheepishly: yeah. I got it working, then saw that and made changes I thought would do what you're suggesting and couldn't get it working again. Lazily, I reverted back to what was working and pushed the pull request.
I'll work on this a bit more.
added 2 commits
January 1, 2019 11:04
Disable all battery code if battery not selected in options. Refactors widgetCount to localize use.
|
|
Looks good, thanks for this! I changed 2 things:
|
|
Ok, thanks; I like your choice of options. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a widget for battery level. The widget updates on the level of minutes, as batteries drain and charge slowly.
The battery widget is disabled by default; it can be enabled with
-b.