Skip to content
This repository has been archived by the owner on Aug 29, 2020. It is now read-only.

remove vendor #73

Merged
merged 1 commit into from
Nov 30, 2018
Merged

remove vendor #73

merged 1 commit into from
Nov 30, 2018

Conversation

h8liu
Copy link
Contributor

@h8liu h8liu commented Nov 30, 2018

No description provided.

@h8liu
Copy link
Contributor Author

h8liu commented Nov 30, 2018

otherwise github.com/cjbassi/gotop/src/widgets won't build without go modules.

@h8liu
Copy link
Contributor Author

h8liu commented Nov 30, 2018

example build failure: https://gopkgs.io/builds/20181130-022153-94e30741

@cjbassi
Copy link
Owner

cjbassi commented Nov 30, 2018

Thanks, I forgot I was vendoring but I would actually like to delete the vendoring if I can. Would/does gotop run correctly without a vendor directory?

@cjbassi
Copy link
Owner

cjbassi commented Nov 30, 2018

For someone without Go modules I mean?

@h8liu h8liu changed the title update vendor remove vendor Nov 30, 2018
@h8liu
Copy link
Contributor Author

h8liu commented Nov 30, 2018

Would/does gotop run correctly without a vendor directory?

it seems to be working currently. without vendor, there is no guarantee since upstream changes can break stuff in the future, though gopkgs.io will capture those breakages.

@cjbassi
Copy link
Owner

cjbassi commented Nov 30, 2018

Thanks, that makes sense. I'll merge this and add a notice to the README about go geting requiring Go 1.11+.

@cjbassi cjbassi merged commit dfc62e6 into cjbassi:master Nov 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants