Skip to content

Commit

Permalink
Merge branch 'master' into session-url-params-on-head
Browse files Browse the repository at this point in the history
* master: (51 commits)
  start to use the debug module.
  v0.34.0: release
  internal: provide unique failure messages for invalid signatures. Fixes node-saml#146
  package.json: bump version to 0.33.0
  docs: mention that disableRequestAuthnContext helps with AD FS
  New Feature: allow customizing the name of the strategy.
  bump version to v0.32.1
  README: link to where our Changes are documented.
  Audience validation
  README: fix typo `s/ADSF/ADFS/`
  jshint: fix jshint violation.
  v0.31.0 release
  README: update link description for ADFS docs.
  Upd: Mention ADFS 2016 with NameIDFormatError. (node-saml#242)
  Support multiple and dynamic signing certificates (node-saml#218)
  v0.30.0
  Ignore .tern-port files
  Use crypto.randomBytes for ID generation (node-saml#235)
  BugFix: Fail gracefully when SAML Response is invalid. Fixes node-saml#238
  docs: Improve docs for privateKey format. Ref node-saml#230
  ...

# Conflicts:
#	README.md
#	test/samlTests.js
#	test/tests.js
  • Loading branch information
cjbarth committed Sep 10, 2018
2 parents a2f2682 + f8140aa commit c917ab6
Show file tree
Hide file tree
Showing 5 changed files with 33 additions and 26 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
node_modules/
.tern-port
6 changes: 0 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
language: node_js
node_js:
- "0.10"
- "0.12"
- "iojs"
- "4.0"
- "stable"

before_install:
- npm install -g npm

script:
- npm test
- ./node_modules/.bin/jshint lib
Binary file added docs/adfs/NameIDFormatError.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 16 additions & 0 deletions docs/adfs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,19 @@ module.exports = passport;

var server = http.createServer(app);
```
# Troubleshooting

## ADFS 2016

If you are setting up an ADFS 2016 server, you might run into the following issue with the previous settings:

```
An error occurred during an attempt to read the federation metadata. Verify that the specified URL or host name is a valid federation metadata endpoint.
Verify your proxy server setting. For more information about how to verify you proxy sever setting, see the AD FS Troubleshooting Guide http://go.microsoft.com/fwlink/?LinkId=182180).
Error message: EntityDescriptor 'acme_tools_com'. ID0014: The value 'NamelDFormat' must be an absolute URI.
```

![NamelDFormat Error Popup](./NameIDFormatError.jpg)

If you remove the `identifierFormat`, it works as expected.
36 changes: 16 additions & 20 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
{
"name": "passport-saml",
"version": "0.15.0",
"licenses": [
{
"type": "MIT",
"url": "https://github.com/bergie/passport-saml/raw/master/LICENSE"
}
],
"version": "0.35.0",
"license": "MIT",
"keywords": [
"saml",
"adfs",
Expand All @@ -22,35 +17,36 @@
"contributors": [
"Michael Bosworth",
"Herbert Vojčík",
"Peter Loer"
"Peter Loer",
"Mark Stosberg"
],
"repository": {
"type": "git",
"url": "https://github.com/bergie/passport-saml.git"
},
"main": "./lib/passport-saml",
"dependencies": {
"debug": "^3.1.0",
"passport-strategy": "*",
"q": "1.1.x",
"q": "^1.5.0",
"xml-crypto": "^0.10.1",
"xml-encryption": "^0.11.0",
"xml2js": "0.4.x",
"xml-crypto": "0.8.x",
"xmldom": "0.1.x",
"xmlbuilder": "2.5.x",
"xml-encryption": "~0.7"
"xmlbuilder": "^9.0.4",
"xmldom": "0.1.x"
},
"devDependencies": {
"body-parser": "1.9.x",
"ejs": "1.0.x",
"express": "4.x",
"body-parser": "^1.17.1",
"express": "^4.16.2",
"jshint": "*",
"mocha": "*",
"request": "*",
"passport": "0.4.x",
"request": "^2.83.0",
"should": "*",
"sinon": "^1.10.2",
"passport": "0.3.x"
"sinon": "^2.1.0"
},
"engines": {
"node": ">= 0.8.0"
"node": ">= 4"
},
"scripts": {
"test": "mocha",
Expand Down

0 comments on commit c917ab6

Please sign in to comment.