-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gittorrentd: Check cwd for .git/, too. #27
base: master
Are you sure you want to change the base?
Conversation
well, my thing is different: you seem to be wanting to torrent the git repository in the current directory. my PR adds bare repository support. i think your PR is still relevant because of POLA... |
Oh, I misread your PR (and misunderstood what "bare" meant). I had looked for a way to express the subdirectory being option, without using |
maybe |
|
Oh wait, doesn't work if the |
Use this: glob.sync('{,.git/,*/.git/}git-daemon-export-ok') |
👍 but it's requires a |
@splinterofchaos #29 was merged, i suggest you reroll this PR... |
the reason why i didn't do it was that i wasn't sure it would work with no subdirs... and i couldn't test it easily. |
.git/git-daemon-export-ok may exist relative to the current directory, and the user may not want to supply all repositories from its parent.
Rebased.
Thanks, fixed. EDIT: Actually, fixed is not the word I'd use: better. Do we use the information of the repository's name to inform peers that our branches/sha's beling to it? I think we need a better way of identifying them as directory names might not correspond one-to-one with repositories. |
From the commit message:
Also, if you have a slow computer like I do and have hundreds of cloned repositories,
glob('*/...')
can take a very long time, making it seem like nothing's happening.Will this file ever contain useful information, because it also might conversely be nice to allow users to pass a flag, like
--export-all
, to supply all repositories whether or not it has a.git/git-daemon-export-ok
file.