-
Notifications
You must be signed in to change notification settings - Fork 87
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
7e16e37
commit 8290109
Showing
1 changed file
with
17 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8290109
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I've pulled instance out of the "wait" block and moved this up to an else (so we don't make the call an extra time for this when we've just made it for the "wait" loop), if they didn't wait, is there any point in doing this - they won't have a PublicIP yet anyway (that happens during building and at this moment if they didn't wait it won't have happened)
Not to mention further down you use
resp
and don't actually use this object from the API call.@alejandrojnm
8290109
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense, I didn't see it that way but it's much better this way