Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix individual org page not showing projects (#1113) #1117

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Conversation

bruceplai
Copy link
Member

Closes #1113
Closes #1115

  • Update query for GitHub API

  • Update project sorting

* Update query for GitHub API

* Update project sorting
@codeclimate
Copy link

codeclimate bot commented Jan 10, 2022

Code Climate has analyzed commit 36f49e6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 83.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 80.9% (-1.0% change).

View more on Code Climate.

@fyliu
Copy link
Contributor

fyliu commented Jan 11, 2022

Looks like the 4 requests for index contributor projects is now reduced to 1. The code for buffalo page is now showing the correct project.

I see the contributing project is showing up in the code for buffalo page, so that works.

Is there some way to reduce the duplicate calls to the backend?

Before:
main branch Screenshot from 2022-01-10 15-00-16

After:
indv-org-1113 Screenshot from 2022-01-10 15-01-29

@bruceplai bruceplai requested a review from nrrao January 11, 2022 02:39
@nrrao nrrao self-assigned this Jan 11, 2022
Copy link
Member

@nrrao nrrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bruceplai bruceplai merged commit e41be3e into main Jan 11, 2022
@bruceplai bruceplai deleted the indv-org-1113 branch January 11, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projects not showing up under individual org page for index contributors Too many API requests from frontend
3 participants