Fix test failing because of react error boundaries #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, now it is failing for older react versions 😿 I'll try something else |
|
It's working now 🎉 |
lencioni
reviewed
Oct 4, 2017
test/waypoint_test.jsx
Outdated
| this.props.children = [ | ||
| <div key={1} />, | ||
| <div key={2} />, | ||
| <div key={3} />, | ||
| ]; | ||
|
|
||
| expect(this.subject).toThrowError(notValidErrorMessage); | ||
|
|
||
| window.onerror = undefined; |
There was a problem hiding this comment.
If window.onerror had been previously set to something else, this will break it. It would be a good idea to store the original value before assigning it, and then set it back to that here.
There was a problem hiding this comment.
Yep, forgot about that! Fixed :)
lencioni
approved these changes
Oct 4, 2017
|
Thanks for fixing this! |
|
No problem! Happy to help! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the test that was disabled due to the React 16 error boundaries handling: #215 (comment)
I found out that with error boundaries, error throws twice in development mode, here is a justification for that from React team: facebook/react#10384 (comment)
I found a fix for that although it looks a little hacky. The other option could be to run tests in
productionmode, but that breaks debug tests and I'm not sure how to fix this.