Update for fixing python3 dependencies #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only contains fixes needed for check_keepalived.py |
Skipper126
reviewed
Jun 20, 2023
There was a problem hiding this comment.
Not sure if its needed, but if this file is called from other scripts running Python 2, then they will no longer work. Adding "from _future_ import print_function" at the top of this file might fix that, so that this file will work for both versions of interpreter.
There was a problem hiding this comment.
I doubt there is any < python3 running this, or even if this is used by anyone, but then again I didn't know this existed until today so it doesn't hurt. Pushed new commit. Thanks
tobberydberg
approved these changes
Jun 20, 2023
Skipper126
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.