Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for .stl export #66

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Conversation

duswie
Copy link
Contributor

@duswie duswie commented Oct 21, 2020

added support for exporting to .stl files.
triangulate_face(..) was slightly changed to return the face normal. Tests are included.

Is it planned to move all export functions to convert.py?
I have thought about combining export stl and obj in the future and moving them there.

@balazsdukai
Copy link
Member

First of all, welcome @Dadley and thank you for your contribution to cjio! Your very first, I think 🥳
The PR technically looks good, I tested the exporter a bit and it works fine.

Indeed, the plan is to move out all the exporters from the cityjson module to convert and make them functions instead methods. This means that ideally the stl exporter would be in convert too, similar to the glb or b3dm converters. This architecture will make it easier to eventually separate the various exporters into a standalone package to make it easier to maintain and to contribute to it.
However, I left the stl exporter as it is for now and I'll merge the PR since its been long open.

Please feel free to move the stl export to convert in separate PR, if you feel like doing it.
Re combining the stl and obj exporter. I'm not sure exactly what do you mean, so if you open another PR with a suggestion that would help the discussion.

@balazsdukai balazsdukai merged commit 83fd03b into cityjson:develop Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants