Feature/cjio metadata #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All code should be in that function in cityjson.py
If datasetReferenceDate is found inside the metadata, then we are not overwritting it anymore.
This is not useful anymore, since it's calculated by the update_metadata function.
It was broken when the vertices list was empty
Also make the identifier in lineage description more descriptive.
balazsdukai
approved these changes
Jul 28, 2020
|
I was in such a haste to finally submit to this 🙈 so forgot to thank @liberostelios for all the help! Especially with the unit tests 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following has been added:
get_metadata: simply views the metadata present in a file.update_metadata: automatically generates metadata for categories that can be automatically generated. There is an overwrite option, by default it's false but can be set to true. UUID and date of creation are not overwritten if they already exist. Existing categories are also maintained if they exist.removed
update_bboxcommand, should be done via metadata.lineage is automatically created and the metadata is updated for
subset,partition,mergeandextract_lod. Forsubset,partition(not sure if it will remain in cjio, but it's there), andextract_loda new UUID is generated for the output saved file. Also we maintain many variable from the original data so this solves the reference system issue mentioned in Subset loses reference system #55.Decision making steps are documented in the commits. If this is approved I can explain all this on the website and cjio help. Yay versioning!