-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds additional citus and django versions #197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #197 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 1193 1202 +9
=========================================
+ Hits 1193 1202 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gurkanindibay
changed the title
Adds citus and django versions
Adds additional citus and django versions
Sep 22, 2023
agedemenli
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we added additional Citus and Django versions into support matrix.
Added Citus version: 12
Added Django Version: 4.1, 4.2
With 4.2, in transactions BEGIN and COMMIT statements have been added. Therefore, in query count comparisons, expected query_count should be increased by 2.
In the sample test output below, you can see the begin and commit statements
https://github.com/citusdata/django-multitenant/actions/runs/6273840069/job/17038085255#step:3:183