Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semicolon bug #167

Merged
merged 5 commits into from
Jan 7, 2016
Merged

Semicolon bug #167

merged 5 commits into from
Jan 7, 2016

Conversation

andyg7
Copy link
Contributor

@andyg7 andyg7 commented Jan 6, 2016

Just got rid of unnecessary semicolon. Also edited DepthFirstSearch.java - should we not do stack.removeFirst() on line 170? I've added more detail on the actual commit (https://github.com/andyg7/hipster/commit/dde3cf3b793a4c9dd4b3abb4a7e71f3703b8e72e)

@codecov-io
Copy link

Current coverage is 53.90%

Merging #167 into 1.0.X will increase coverage by +1.07% as of 6cd901d

@@            1.0.X   #167   diff @@
====================================
  Files          57     58     +1
  Stmts        1622   1714    +92
  Branches      264    274    +10
  Methods                        
====================================
+ Hit           857    924    +67
- Partial        63     67     +4
- Missed        702    723    +21

Review entire Coverage Diff as of 6cd901d

Powered by Codecov. Updated on successful CI builds.

@pablormier
Copy link
Contributor

It seems that you're right. Could you please add that graph example as a test? Many thanks!

@andyg7
Copy link
Contributor Author

andyg7 commented Jan 7, 2016

Just pushed that test - created a new file UndirectedGraphSearchExample.java in hipster-examples where I implement the DFS search.

@pablormier
Copy link
Contributor

Thanks!

pablormier added a commit that referenced this pull request Jan 7, 2016
Fixed incorrect node processing in DFS
@pablormier pablormier merged commit 3f90e4d into citiususc:1.0.X Jan 7, 2016
@andyg7
Copy link
Contributor Author

andyg7 commented Jan 7, 2016

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants