Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrib/issue 64 #160

Merged
merged 3 commits into from
Dec 22, 2015
Merged

Contrib/issue 64 #160

merged 3 commits into from
Dec 22, 2015

Conversation

michaelhaaf
Copy link
Contributor

Closes issue 64 (have IDA* extend DFS to remove duplicated code)

@codecov-io
Copy link

Current coverage is 52.83%

Merging #160 into 1.0.X will increase coverage by +0.36% as of b633b0d

@@            1.0.X    #160   diff @@
=====================================
  Files          57      57       
  Stmts        1654    1622    -32
  Branches      268     264     -4
  Methods                         
=====================================
- Hit           868     857    -11
+ Partial        66      63     -3
+ Missed        720     702    -18

Review entire Coverage Diff as of b633b0d

Powered by Codecov. Updated on successful CI builds.

@@ -40,39 +37,18 @@
* @param <C> comparable cost used to compare states.
* @param <N> type of the heuristic search node.
*
* @author Pablo Rodríguez Mier <<a href="mailto:[email protected]">[email protected]</a>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the implementation is not completely yours, it is better to maintain the original authors, you can add yourself below. Also, it is ok if you want to specify an email address (or github profile) if you want to give more details about you, although not required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, totally valid. I think I was blindly accepting merges. Will fix.

pablormier added a commit that referenced this pull request Dec 22, 2015
@pablormier pablormier merged commit 77db942 into citiususc:1.0.X Dec 22, 2015
@pablormier
Copy link
Contributor

Thanks, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants