Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When checking if point in bounds, also check lower bounds. #144

Closed
gahrae opened this issue Aug 27, 2015 · 0 comments
Closed

When checking if point in bounds, also check lower bounds. #144

gahrae opened this issue Aug 27, 2015 · 0 comments

Comments

@gahrae
Copy link
Contributor

gahrae commented Aug 27, 2015

The method pointInBounds of class Maze2D checks if a point is within the bounds of a board. However, it does not check the lower bounds. That is, x >= 0, and y >= 0.

I will submit a pull request shortly to fix this issue.
pablormier added a commit that referenced this issue Aug 27, 2015
@pablormier
Merge pull request #145 from gahrae/contrib/issue-144
0bf187f 
fix #144 : Make Maze2D.pointInBounds() check lower bounds too.
michaelhaaf pushed a commit to michaelhaaf/hipster that referenced this issue Dec 2, 2015
@gahrae
fix citiususc#144 : Make Maze2D.pointInBounds() check lower bounds too.
414b0cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gahrae