Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update universite-de-sherbrooke-histoire.csl #7263

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update universite-de-sherbrooke-histoire.csl #7263

wants to merge 2 commits into from

Conversation

leonrobichaud
Copy link
Contributor

Added match="any" to

@leonrobichaud
Update universite-de-sherbrooke-histoire.csl
f296bbe 
Added match="any" to 
<else-if type="interview graphic">
@github-actions GitHub Actions
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions GitHub Actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

universite-de-sherbrooke-histoire.csl (modified style)
Bob Hancké, Martin Rhodes et Mark Thatcher, dir., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press ; , 2007 ; « CSL search by example », Citation Style Editor ; , 2012, http://editor.citationstyles.org/searchByExample/, .
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice, dir., Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press ; , 2001, p. 184‑213, ,  ; Martin Fenner et al., « A data citation roadmap for scholarly data repositories », Scientific Data ; , vol. 6, n° 1, avril 2019, p. 28, http://www.nature.com/articles/s41597-019-0031-8, 10.1038/s41597-019-0031-8.
« CSL search by example », Citation Style Editor, , 2012, http://editor.citationstyles.org/searchByExample/.
Fenner, Martin et al., « A data citation roadmap for scholarly data repositories », Scientific Data, vol. 6, n° 1, avril 2019, p. 28, http://www.nature.com/articles/s41597-019-0031-8, 10.1038/s41597-019-0031-8.
Hancké, Bob, Martin Rhodes et Mark Thatcher, dir., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007.
Mares, Isabela, « Firms and the welfare state: When, why, and how does social policy matter to employers? », Dans Peter A. Hall et David Soskice, dir., Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213.
-Bob Hancké, Martin Rhodes et Mark Thatcher, dir., <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>, Oxford and New York, Oxford University Press ; , 2007 ; « CSL search by example », <i>Citation Style Editor</i> ; , 2012, http://editor.citationstyles.org/searchByExample/.<br/>
-Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », <span style="font-style: normal">dans</span> Peter A. Hall et David Soskice, dir., <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, New York, Oxford University Press ; , 2001, p. 184‑213 ; Martin Fenner <i>et al.</i>, « A data citation roadmap for scholarly data repositories », <i>Scientific Data</i> ; , vol. 6, n° 1, avril 2019, p. 28, http://www.nature.com/articles/s41597-019-0031-8.<br/>
+Bob Hancké, Martin Rhodes et Mark Thatcher, dir., <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>, Oxford and New York, Oxford University Press ; , 2007 ; « CSL search by example », <i>Citation Style Editor</i> ; , 2012, http://editor.citationstyles.org/searchByExample/, .<br/>
+Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », <span style="font-style: normal">dans</span> Peter A. Hall et David Soskice, dir., <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, New York, Oxford University Press ; , 2001, p. 184‑213, ,  ; Martin Fenner <i>et al.</i>, « A data citation roadmap for scholarly data repositories », <i>Scientific Data</i> ; , vol. 6, n° 1, avril 2019, p. 28, http://www.nature.com/articles/s41597-019-0031-8, 10.1038/s41597-019-0031-8.<br/>
 <hr/>
 « CSL search by example », <i>Citation Style Editor</i>, , 2012, http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner, Martin <i>et al.</i>, « A data citation roadmap for scholarly data repositories », <i>Scientific Data</i>, vol. 6, n° 1, avril 2019, p. 28, http://www.nature.com/articles/s41597-019-0031-8.<br/>
+Fenner, Martin <i>et al.</i>, « A data citation roadmap for scholarly data repositories », <i>Scientific Data</i>, vol. 6, n° 1, avril 2019, p. 28, http://www.nature.com/articles/s41597-019-0031-8, 10.1038/s41597-019-0031-8.<br/>
 Hancké, Bob, Martin Rhodes et Mark Thatcher, dir., <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>, Oxford and New York, Oxford University Press, 2007.<br/>
 Mares, Isabela, « Firms and the welfare state: When, why, and how does social policy matter to employers? », <span style="font-style: normal">Dans</span> Peter A. Hall et David Soskice, dir., <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, New York, Oxford University Press, 2001, p. 184‑213.<br/>

@bwiernik
Copy link
Member

bwiernik commented Oct 16, 2024 •
edited
Loading

Thanks, looking at the example output for items in the comment above, there are several places where there are extra pieces of punctuation added. See the Bob Hancké et al. book and Citation Style Language website before the date, after the URL, and after the page number.

This is happening because punctuation is being added as prefix/suffix, rather than as a delimiter on a <group> element. I see that you already replaced some of these prefix/suffix with delimiters instead.

Could you go through the style and fix those issues in the other places?

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Oct 16, 2024
@bwiernik
Copy link
Member

(If possible, please make the changes in this PR rather than opening a new one)

@leonrobichaud
Copy link
Contributor Author

leonrobichaud commented Oct 17, 2024 via email

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonrobichaud @bwiernik