Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verb form of terms "hearing", "review", "review-book" #291

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

bwiernik
Copy link
Member

@adam3smith What do you think of this?

"hearing" is an item type term rather than a role term, but it makes sense to me to use the verb form of the term to refer to the author/giver of testimony at the hearing

This would be used for localizing phrasing like (testimony of <author>)

@adam3smith What do you think of this?

"hearing" is an item type term rather than a role term, but it makes sense to me to use the verb form of the term to refer to the author/giver of testimony at the hearing

This would be used for localizing phrasing like `(testimony of <author>)`
@bwiernik bwiernik changed the title Add verb form of term "hearing" Add verb form of terms "hearing", "review", "review-book" Sep 20, 2023
@bwiernik
Copy link
Member Author

@adam3smith I'm done adding things here for now.

@bwiernik
Copy link
Member Author

@adam3smith Are you okay with merging this?

@adam3smith adam3smith merged commit f6f859c into master Feb 13, 2024
1 check passed
@adam3smith
Copy link
Member

The only controversial bit is hearing I guess, but why not?

@bwiernik bwiernik deleted the hearing-verb branch February 13, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants