Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Latin locale code #188

Merged
merged 3 commits into from
Jan 23, 2019
Merged

Correct Latin locale code #188

merged 3 commits into from
Jan 23, 2019

Conversation

adunning
Copy link
Contributor

Correcting my error in #186.

@csl-bot
Copy link
Contributor

csl-bot commented Jan 23, 2019

Awesome! You just created a pull request to the Citation Styles Language locales repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your locale file validates.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your locale file to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot
Copy link
Contributor

csl-bot commented Jan 23, 2019

Uh-oh! Looks like there are (still) some issues with your submission. Please check the latest test report for details.

@csl-bot
Copy link
Contributor

csl-bot commented Jan 23, 2019

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@rmzelle rmzelle merged commit 9cfdca4 into citation-style-language:master Jan 23, 2019
@rmzelle
Copy link
Member

rmzelle commented Jan 23, 2019

Thanks! (our automatic tests are set up in such a way that we have to make explicit exceptions for locale codes without a region)

@adunning adunning deleted the patch-1 branch January 23, 2019 11:35
@adunning
Copy link
Contributor Author

Thank you for catching it! It's doubly embarrassing because I had made a proposal to the IETF a couple of years ago to create Latin variant tags corresponding to the private-use la-x-classic and la-x-liturgic tags that TeX Hyphenation uses. They felt in the event that regional codes were good enough – I've tended to use la for classical Latin; la-VA for ecclesiastical Latin (if there is such a thing); la-EU for neo-Latin; la-GB for Anglo-Latin; la-FR for Gallo-Latin; etc. But there aren't many occasions on which one needs these.

@rmzelle
Copy link
Member

rmzelle commented Jan 23, 2019

Ah, well, in that case I agree with you :). Most of us are not exactly well-versed in the arcane knowledge of locale codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants