remove A*GCMKW support #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuxwolf
requested changes
Jan 30, 2018
There was a problem hiding this comment.
Overall looks really good. If you're ok with it, you should add yourself to AUTHORS (it's meant to be a list of contributors, but naming it this way helps other tooling).
There's one correct I'd like reverted (see review). Also, see https://github.com/panva/node-jose/pull/1 for a potential fix to the test failure.
lib/algorithms/aes-gcm.js
Outdated
| @@ -326,10 +326,7 @@ var aesGcm = {}; | |||
| [ | |||
| "A128GCM", | |||
| "A192GCM", | |||
| "A256GCM", | |||
| "A128GCMKW", | |||
There was a problem hiding this comment.
I'd rather keep these in here, and rely on their removal from the supported algorithms list in jwk/octkey.js
|
requested changes are in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #133