Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service principal fix and plugin name fixes #7

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

DodinViorel
Copy link
Contributor

Description

  • Token was not populated in the bearer header for any other authentication methods besides OAuth
  • Binary name must match the provider name set in the Metadata method and all it's data sources and resources.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Various errors were encountered during testing.
Binnary plugin name and provider name must match.

Signed-off-by: Viorel Dodin <[email protected]>
@DodinViorel DodinViorel requested a review from kprav33n April 15, 2024 09:58
Copy link
Contributor

@kprav33n kprav33n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kprav33n kprav33n merged commit d413bbd into cisco-open:main Apr 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants