Support internal and public NAT rules #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughwphamill
commented
Aug 8, 2024
| --- | ||
|
|
||
| # dcloud_external_dns (Data Source) | ||
|
|
||
| All the dns records currently in a given topology | ||
| All the External DNS rules in a given topology |
There was a problem hiding this comment.
The previous version of the docs seem to have been hand edited, they should only be updated by go generate.
This is replacing the hand editing by the generated docs.
The descriptions in the data source code should be updated to the correct wording, I'll open an issue for this as it's outside the scope of this change.
philipowen
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support OPTIONAL
scopefield on both IP and VM NAT RulesType of Change
Checklist