Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce and defer #38

Merged
merged 11 commits into from
Jan 6, 2024
Merged

Debounce and defer #38

merged 11 commits into from
Jan 6, 2024

Conversation

geoffhendrey
Copy link
Contributor

@geoffhendrey geoffhendrey commented Jan 4, 2024

Description

Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.

Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.

Type of Change

  • Bug Fix
  • [ x] New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@geoffhendrey geoffhendrey requested a review from a team as a code owner January 4, 2024 15:47
zhirafovod
zhirafovod previously approved these changes Jan 4, 2024
@geoffhendrey
Copy link
Contributor Author

@zhirafovod if you have a chance, a review of this would be great. Nothing deep. If what I put int he readme makes sense, i think we are good. Also, check out the new "--tail until " (you can see it used in readme.md). The design discussion w nachi is captured here: https://confluence.corp.appdynamics.com/display/[email protected]/discussion+of+defer+function
I did a lot of cleanups and refactors in TemplateProcessor.ts. The new functionality is here:
https://github.com/cisco-open/stated/pull/38/files#diff-576871674848cbd1c9f681fed62a7ccb934e54483d9f9284d36cb2c573e8d1bdR1340
It required that the changeCallbacks support multiple callbacks for any given jsonpointer into the document. This was always needed but just never got around to it. Even external users of TemplateProcessor may want 5 different callbacks for differnent purposes to monitor a given piece of the template for change. Actually need to go back and do the same thing for the commonCallback.

Copy link
Member

@zhirafovod zhirafovod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving the README and --tail functionality, and linking the design discussion. It really helps!

@geoffhendrey geoffhendrey merged commit b189b46 into main Jan 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants