refactor: run post_setup script on init #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myungjin
reviewed
Aug 28, 2024
multiworld/__init__.py
Outdated
|
|
||
| try: | ||
| post_setup.main() | ||
| except Exception as e: |
There was a problem hiding this comment.
please remove this try-except statements. This simply catches the error but doesn't stop the script. This can cause confusion.
|
The two lines here(https://github.com/cisco-open/pymultiworld/blob/main/pyproject.toml#L16-L17) should be removed. |
|
https://github.com/cisco-open/pymultiworld/blob/main/multiworld/__main__.py file is also not needed any more. Please remove it. |
made changes to that post_setup script is executed in __init__.py of multiworld error handlers were while executing the main method. with the first execution, the patch is applied and the user is prompted to re-run the script to have the patched version of torch
raresgaia123
force-pushed
the
auto_patch
branch
from
6fd6bbe to
7d833d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made changes to that post_setup script is executed in init.py of multiworld error handlers were while executing the main method. with the first execution, the patch is applied and the user is prompted to re-run the script to have the patched version of torch
Description
Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.
Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.
Type of Change
Checklist