refactor: restructuring packaging #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, world_manager.py and world_communicator.py are copied into torch package and they become part of torch after installing multiworld. This is inappropriate. We keep those files under multiworld package, but we patch pytorch such that the variables (_worlds, _World, etc) required by multiworld are exposed by patching __init__.py in distributed module. Therefore, pytorch patch file is updated and all other necessary changes are made to ensure that all the examples can be executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, world_manager.py and world_communicator.py are copied into torch package and they become part of torch after installing multiworld. This is inappropriate. We keep those files under multiworld package, but we patch pytorch such that the variables (_worlds, _World, etc) required by multiworld are exposed by patching init.py in distributed module. Therefore, pytorch patch file is updated and all other necessary changes are made to ensure that all the examples can be executed.
Type of Change
Checklist