Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download: if the lock file does not exist, error #13

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jsquyres
Copy link
Contributor

@jsquyres jsquyres commented Mar 26, 2024

Description

If we grabit download --lock-file foo and the file foo does not exist, that should emit an error. Likewise, if you grabit download and rely on the default grabit.lock file to exist, we should also error if that file does not exist.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
    • I'm happy to document it, but I'm not sure where is appropriate.
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

If we `grabit download --lock-file foo` and the file `foo` does not
exist, that should emit an error.  Likewise, if you `grabit download`
and rely on the default `grabit.lock` file to exist, we should also
error if that file does not exist.

Signed-off-by: Jeff Squyres <[email protected]>
Copy link
Contributor

@rabadin rabadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@rabadin rabadin merged commit afaa354 into main Mar 26, 2024
3 checks passed
@jsquyres jsquyres deleted the pr/bogus-lock-file-on-download-should-error branch March 26, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants