This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
creating new radius and tacacs data classes #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renukavinay
reviewed
Sep 5, 2024
sbasan
reviewed
Sep 5, 2024
smialy
approved these changes
Sep 6, 2024
sbasan
approved these changes
Sep 6, 2024
sbasan
pushed a commit
that referenced
this pull request
Sep 11, 2024
* updating radius and tacacs data classes for new changes * fix static * fix static * make vpn vpn id optional * sub class * match with parent class * match with parent class * match with parent class * snake case * description * src checks * src checks * src checks
sbasan
added a commit
that referenced
this pull request
Sep 11, 2024
* Merge pull request #795 from cisco-open/apigw Add API GW login. Refactor session related files. * Added validation activities when TaskValidationError is raised * Bump actions/setup-python from 5.1.1 to 5.2.0 (#809) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.1.1 to 5.2.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@39cd149...f677139) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * creating new radius and tacacs data classes (#815) * updating radius and tacacs data classes for new changes * fix static * fix static * make vpn vpn id optional * sub class * match with parent class * match with parent class * match with parent class * snake case * description * src checks * src checks * src checks * Add staging * bump up version * fix: provider as tenant login (#820) * draft * bump version * update env variables usage * bump dev version 0.35.3dev0 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jakub Krajewski <[email protected]> Co-authored-by: Bartlomiej Radwan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: nikhilkp93 <[email protected]> Co-authored-by: Jakub Krajewski <[email protected]> Co-authored-by: Nikhil <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request summary:
creating new radius and tacacs data classes.
We would need couple of new options based on whether user wants to select vpn directly or if they want to select source VPN along with VXLAN tunnel.
Description of changes:
When we use direct VPN0/VPN512, and use vpn,vpn subnet ip, it will fail. it only needs source vpn, which is not there.
On the other hand, when we use VPN 512 via VXLAN, then sourcevpn, vpn, vpn subnet ip are requited. Which is also not there.
Hence we need new data classes
Checklist: