Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

[fix] tags field for DeviceDetailsResponse #26

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Conversation

cicharka
Copy link
Collaborator

@cicharka cicharka commented Apr 17, 2024

Pull Request summary:

Fix for tags field for DeviceDetailsResponse, example payload used (simplified for tags only):

device = DeviceDetailsResponse(
    ...
    'id': 'NA',
    'tags': [{'name': 'XXXX',
              'type': 'USER',
              'id': '348a2546-7db2-4495-9b98-145144f12ccf',
              'description': 'XXX'}],
    'solution': 'NA',
    ...
}

Description of changes:

[Add more in depth analysis of what changed, provide logs, examples of usage]

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

JimOverholt
JimOverholt previously approved these changes Apr 17, 2024
@cicharka cicharka marked this pull request as draft April 18, 2024 09:21
@cicharka cicharka marked this pull request as ready for review April 19, 2024 08:00
@sbasan sbasan requested a review from JimOverholt April 22, 2024 10:34
@JimOverholt JimOverholt merged commit f168269 into main Apr 22, 2024
10 checks passed
@JimOverholt JimOverholt deleted the fix/devicedetailstags branch April 22, 2024 15:40
@JimOverholt JimOverholt mentioned this pull request Apr 25, 2024
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants