Certificate data class requires rework

[JimOverholt]

Summary

I'm trying to set vManage controller certificate to enterprise and upload root ca. In the old python-viptela library all I needed to do it:

Settings(vmanage_session, vmanage_ip).set_vmanage_ca_type('enterprise')
Settings(vmanage_session, vmanage_ip).set_vmanage_root_cert(ca_chain, 240)

The catalyst wan libarary certificate class requires a lot of parameters that are not mandatory when using enterprise CA option:

class Certificate(DataclassBase):
    controller_certificate: str = field(metadata={FIELD_NAME: "certificateSigning"})
    first_name: str = field(metadata={FIELD_NAME: "firstName"})
    last_name: str = field(metadata={FIELD_NAME: "lastName"})
    email: str = field(metadata={FIELD_NAME: "email"})
    validity_period: ValidityPeriod = field(metadata={FIELD_NAME: "validityPeriod"})
    retrieve_interval: int = field(converter=str, metadata={FIELD_NAME: "retrieveInterval"})

    @retrieve_interval.validator  # type: ignore
    def retrieve_interval_is_valid(self, attribute, value):
        RETRIEVE_INTERVAL_MAX = 60
        RETRIEVE_INTERVAL_MIN = 1
        if not RETRIEVE_INTERVAL_MIN <= int(value) <= RETRIEVE_INTERVAL_MAX:
            raise RetrieveIntervalOutOfRange("Retrieve interval must be value between 1 and 60 minutes")

There are two problems here:

1. When configuring the 'enterprise' as controller certificate authorization, the vManage API required only "controller_certificate" field set to enterprise and all other fields shouldn't be there. But the current code doesn't allow for it.
2. The code doesn't allow to upload enterprise root CA in any way.

Logs and external information

No response

Reproduction script

vmanage_settings = AdministrationSettingsAPI(vmanage_session)
vmanage_settings.update(Certificate('enterprise'))

On what platform(s) does it occur?

Not Applicable

Issue Severity

High: Blocking everything

[JimOverholt]

This issue was migrated from an old repository: CiscoDevNet/catalystwan#460