Add read-all perm. Generate run_id instead of taking from env variable

cisco-open · Jul 15, 2024 · 45bba1a · 45bba1a
1 parent 64db56d
commit 45bba1a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/integrationtests.yml b/.github/workflows/integrationtests.yml
@@ -3,6 +3,8 @@ on:
     branches:
       - dev-uxmt
 
+permissions: read-all
+
 # This ensures only one job runs at a time across all workflows
 concurrency: 
   group: integration_tests
@@ -18,7 +20,6 @@ jobs:
       VMANAGE_USERNAME: ${{ secrets.VMANAGE_USERNAME }}
       VMANAGE_PASSWORD: ${{ secrets.VMANAGE_PASSWORD }}
       VMANAGE_PORT: ${{ secrets.VMANAGE_PORT }}
-      RUN_ID: ${{ github.event.pull_request.number }}
       CATALYSTWAN_DEVEL: true
     defaults:
       run:

diff --git a/catalystwan/integration_tests/base.py b/catalystwan/integration_tests/base.py
@@ -3,7 +3,7 @@
 import os
 import unittest
 from typing import Union
-from uuid import UUID
+from uuid import UUID, uuid4
 
 from packaging.version import Version  # type: ignore
 
@@ -22,7 +22,7 @@
 
 logger = logging.getLogger(__name__)
 
-RUN_ID: int = int(os.environ.get("RUN_ID", 0))
+RUN_ID: str = str(uuid4())[:4]
 
 
 def create_session() -> ManagerSession: