Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky network adaptations #7

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

flaky network adaptations #7

wants to merge 3 commits into from

Conversation

sbasan
Copy link
Collaborator

@sbasan sbasan commented Nov 29, 2024 •
edited
Loading

Pull Request summary:

Mitigate SDK hanging during http requests when network is unstable.

Description of changes:

Add default request timeouts and retries.

  • set default request_timeout to 10s in ManagerSession
  • mount HTTPAdapter with sensible retry settings by default in ManagerSession
  • set default request_timeout to 10s in vManageAuth
  • set default request_retries to 1 in vManageAuth

Fix old mypy violations detected incidentally (cherry-picked from already fixed dev branch commit)

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@sbasan sbasan requested a review from brdw87 November 29, 2024 11:55
@sbasan sbasan force-pushed the sbasan/flaky-network-adaptations branch from ea40c43 to 64c4f95 Compare December 2, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brdw87 brdw87 Awaiting requested review from brdw87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sbasan