Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly pass region where needed #20

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

przsus
Copy link
Contributor

@przsus przsus commented Aug 13, 2024

Pull Request summary:

Pass the region value to aws ec2_vpc_subnet_info and ec2_instance_info to make them independent of the existance of aws default config.

Description of changes:

Fixes issue no 18 raised at ansible-collection-sdwan-deployment

Checklist:

  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@przsus przsus requested a review from cicharka August 13, 2024 14:03
@przsus przsus force-pushed the explicitly-pass-region-where-needed branch from 0a7d8d1 to 785aa86 Compare August 13, 2024 14:04
@cicharka
Copy link
Contributor

@cicharka cicharka merged commit 9515671 into main Aug 19, 2024
5 checks passed
@cicharka cicharka deleted the explicitly-pass-region-where-needed branch August 19, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants