Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python version support #90

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Update Python version support #90

wants to merge 3 commits into from

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Feb 3, 2022 •
edited
Loading

🗣 Description

This pull request removes support for Python 3.6 and adds a missing classifier to the package information for Python 3.10.

💭 Motivation and context

Python 3.6 reached end-of-life on 2021-12-23 and so we should not target it for future development.

The classifier for Python 3.10 was missed in #87.

🧪 Testing

Automated tests pass.

⚠ Note

I will remove the Python 3.6 branch protection items before merging.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.
  • Remove Python 3.6 branch protection requirements.

✅ Post-merge checklist

  • Add a tag or create a release.

@mcdonnnj
Add Python 3.10 to package classifiers
3dac989 
This was missed when we added testing/building for Python 3.10.
@mcdonnnj
Drop Python 3.6 support
20a2537 
Python 3.6 reached end-of-life on 2021-12-23 and we should not develop
against an end-of-lifed version.
@mcdonnnj
Bump version from 0.0.1 to 0.1.0
030d740
@mcdonnnj mcdonnnj added blocked This issue or pull request is awaiting the outcome of another issue or pull request breaking change This issue or pull request involves changes to existing functionality labels Feb 3, 2022
@mcdonnnj mcdonnnj requested review from dav3r and felddy as code owners February 3, 2022 15:21
@mcdonnnj mcdonnnj self-assigned this Feb 3, 2022
@mcdonnnj mcdonnnj requested a review from jsf9k as a code owner February 3, 2022 15:21
dav3r
dav3r approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍

@mcdonnnj mcdonnnj mentioned this pull request Feb 28, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request breaking change This issue or pull request involves changes to existing functionality
Projects
Skeleton Maintenance
Status: Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r