Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove two unnecessary pins #142

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove two unnecessary pins #142

wants to merge 1 commit into from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 11, 2024 •
edited
Loading

🗣 Description

This pull request removes two pins in setup.py that are now unnecessary.

💭 Motivation and context

  • The setuptools pin was enforcing a version newer than a version from 2016, which seems unnecessary since we are only supporting Python 3.7 and up.
  • The coveralls pin was enforcing that we not install a particular version from 2020. This again seems unnecessary as we are only supporting Python 3.7 and up.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k
Remove two unnecessary pins
a78f49a 
- The setuptools pin was enforcing a version newer than a version from
2016, which seems unnecessary since we are only supporting Python 3.7
and up.
- The coveralls pin was enforcing that we not install a particular
version from 2020.  This again seems unnecessary as we are only
supporting Python 3.7 and up.
@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use dependencies Pull requests that update a dependency file hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Oct 11, 2024
@jsf9k jsf9k mentioned this pull request Oct 11, 2024
Merged
12 tasks
@jsf9k jsf9k marked this pull request as ready for review October 12, 2024 02:20
@jsf9k jsf9k requested a review from a team October 12, 2024 02:21
dav3r
dav3r approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
dependencies Pull requests that update a dependency file hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Next Kraken
Status: In Progress
Skeleton Maintenance
Status: Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @dv4harr10 @mcdonnnj