Update pre-commit Hooks to Include Bugfix #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pre-commit-terraform` hook since the PR I submitted, antonbabenko/pre-commit-terraform#100, was approved. This will fix issues with `skeleton-tf-module` related to multiple directories with Terraform code.
…hen the failure is with setup rather than hooks running.
…lding. Adjust description for pre-commit hook setup to better convey what is being done.
mcdonnnj
deleted the
bugfix/update_pre-commit_for_pre-commit-terraform_hook
branch
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
The main focus of this PR was to run
pre-commit autoupdateto pull in the latest version of the pre-commit-terraform hook. This version includes the PR I submitted to fix an issue seen in cisagov/skeleton-tf-module with Terraform in sub-directories.I also performed a little bit of housekeeping by sorting the
.gitignorefile, renaming thebuildaction tolintto be more accurately descriptive, and breaking out thepre-commithook environment setup so that it's clearer when environment setup fails (as it was often yesterday), vs when hooks themselves are failing.💭 Motivation and Context
Need the latest version, accurately describing intent is good, and sorted is nice.
🧪 Testing
Automated testing.
📷 Screenshots (if appropriate)
🚥 Types of Changes
✅ Checklist