Switch the pre-commit hook used to run prettier
#186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
improvement
mcdonnnj
requested review from
dav3r,
felddy,
jasonodoom and
jsf9k
as code owners
mcdonnnj
changed the title
prettierpre-commit hook used to run prettier
jsf9k
approved these changes
Aug 13, 2024
mcdonnnj
added
the
kraken 🐙
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
This replaces the now archived pre-commit/mirrors-prettier hook.
mcdonnnj
force-pushed
the
improvement/switch_prettier_hook
branch
from
25e7a4f to
c502f1a
Compare
|
Very late to the game here. But wanted to thank you for making this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request switches the pre-commit hook used to run prettier from pre-commit/mirrors-prettier to rbubley/mirrors-prettier.
💭 Motivation and context
The pre-commit/mirrors-prettier hook has been archived due to changes in the upcoming prettier v4 that "break plugins entirely". A longstanding gripe I have had with the hook is that as soon as a pre-release is cut (basically the first alpha release), the older stable major version no longer gets updated tags. The new hook ignores pre-releases and, so far at least, is only cutting tags for the v3 point releases.
🧪 Testing
Automated tests pass.
✅ Pre-approval checklist