⚠️ CONFLICT! Lineage pull request for: skeleton

[cisagovbot]

Lineage Pull Request: CONFLICT

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-generic.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

1. Take ownership of this pull request by removing any other assignees.

2. Clone the repository locally, and reapply the merge:

   git clone [email protected]:cisagov/skeleton-docker.git skeleton-docker
   cd skeleton-docker
   git remote add skeleton https://github.com/cisagov/skeleton-generic.git
   git remote set-url --push skeleton no_push
   git switch develop
   git checkout -b lineage/skeleton --track origin/develop
   git pull skeleton HEAD
   git status

3. Review the changes displayed by the status command. Fix any conflicts and
   possibly incorrect auto-merges.

4. After resolving each of the conflicts, add your changes to the
   branch, commit, and push your changes:

   git add .pre-commit-config.yaml 
   git commit
   git push --force --set-upstream origin lineage/skeleton

   Note that you may append to the default merge commit message
   that git creates for you, but please do not delete the existing
   content. It provides useful information about the merge that is
   being performed.

5. Wait for all the automated tests to pass.

6. Check the "Everything is cool" checkbox below:

   • ✌️ The conflicts in this pull request have been resolved.

7. Mark this draft pull request "Ready for review".

---

Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

[jsf9k]

@felddy and @mcdonnnj - I feel like this cache key should include the Python version. Is that correct?

[jsf9k]

I asked one question about a cache key that I'd like to see answered. After that I can approve.

[mcdonnnj]

I asked one question about a cache key that I'd like to see answered. After that I can approve.

I noticed it myself after I started looking at this PR and am in the middle of typing up the PR to fix (it). 🦅 👀

[mcdonnnj]

@felddy and @mcdonnnj - I feel like this cache key should include the Python version. Is that correct?

@jsf9k Please see #40

[jsf9k]

Now that @mcdonnnj created #40, that answers my one question. I now hereby approve this pull request with maximum gusto!

[mcdonnnj]

It does the things!

[dav3r]

👍 👍