Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed Cache Key in PR #29 #30

Closed
mcdonnnj opened this issue Sep 4, 2020 · 0 comments · Fixed by #35
Closed

Missed Cache Key in PR #29 #30

mcdonnnj opened this issue Sep 4, 2020 · 0 comments · Fixed by #35
Assignees
Labels
bug This issue or pull request addresses broken functionality

Comments

@mcdonnnj
Copy link
Member

mcdonnnj commented Sep 4, 2020

🐛 Bug Report

When #29 was merged the cache key for the test job was not updated to include requirements.txt like the lint job.

lint job:

key: "lint-${{ runner.os }}-py${{ env.PY_VERSION }}-\
${{ hashFiles('**/requirements-test.txt') }}-\
${{ hashFiles('**/requirements.txt') }}-\
${{ hashFiles('**/.pre-commit-config.yaml') }}"

test job:

key: "test-${{ runner.os }}-\
${{ hashFiles('**/requirements-test.txt') }}"

@mcdonnnj mcdonnnj added the bug This issue or pull request addresses broken functionality label Sep 4, 2020
@felddy felddy self-assigned this Oct 8, 2020
felddy added a commit that referenced this issue Oct 8, 2020
@felddy felddy closed this as completed in #35 Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants