-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible Dependencies for Development #146
Conversation
In addition to pinning dependencies in *master*, it might make sense to keep the *develop* branch nice and flexible, with the expectation that it might break. I think it makes sense to retain the capability to build from "unpublished" source when necessary. As a rule-of-thumb, maybe we also agree that the minimum version accepted by *develop* be the version we pin in *master*.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is definitely better versioning than what we have been using, so I'm approving it. I'm still not sure if this is the optimal solution, though.
What does this add to the release process of a new PyPi version? Do the version numbers have to change each time? Will they stay constantly out of sync between |
@konklone, I think Better would be not to use the current version for each package, but instead figure out the minimum version that will work. |
This is mostly the case now:
Should we identify good minimum versions for the remaining 4 requirements and call it a day? |
I think that's the crux of this PR's principal commit 327ca18. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, needs a minor fix up of a conflict in setup.py
Update the version of the `crazy-max/ghaction-github-labeler` Action and add a dependabot ignore directive
In addition to pinning dependencies in master, it might make sense to keep the develop branch nice and flexible, with the expectation that it might break.
I think it makes sense to retain the capability to build from "unpublished" source when necessary.
As a rule-of-thumb, maybe we also agree that the minimum version accepted by develop be the version we pin in master.