Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible Dependencies for Development #146

Merged
merged 4 commits into from
Apr 6, 2018
Merged

Flexible Dependencies for Development #146

merged 4 commits into from
Apr 6, 2018

Conversation

egyptiankarim
Copy link
Contributor

In addition to pinning dependencies in master, it might make sense to keep the develop branch nice and flexible, with the expectation that it might break.

I think it makes sense to retain the capability to build from "unpublished" source when necessary.

As a rule-of-thumb, maybe we also agree that the minimum version accepted by develop be the version we pin in master.

In addition to pinning dependencies in *master*, it might make sense to keep the *develop* branch nice and flexible, with the expectation that it might break.

I think it makes sense to retain the capability to build from "unpublished" source when necessary.

As a rule-of-thumb, maybe we also agree that the minimum version accepted by *develop* be the version we pin in *master*.
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is definitely better versioning than what we have been using, so I'm approving it. I'm still not sure if this is the optimal solution, though.

@konklone
Copy link
Collaborator

konklone commented Dec 8, 2017

What does this add to the release process of a new PyPi version? Do the version numbers have to change each time? Will they stay constantly out of sync between develop and master?

@jsf9k
Copy link
Member

jsf9k commented Dec 8, 2017

@konklone, I think develop and master always being out of sync is a good point.

Better would be not to use the current version for each package, but instead figure out the minimum version that will work.

@konklone
Copy link
Collaborator

konklone commented Apr 3, 2018

Better would be not to use the current version for each package, but instead figure out the minimum version that will work.

This is mostly the case now:

    install_requires=[
        'requests>=2.18.4',
        'sslyze>=1.4.1',
        'wget>=3.2',
        'docopt',
        'pytablereader',
        'pytablewriter',
        'publicsuffix',
        'pyopenssl>=17.2.0'
    ],

Should we identify good minimum versions for the remaining 4 requirements and call it a day?

@egyptiankarim
Copy link
Contributor Author

Should we identify good minimum versions for the remaining 4 requirements and call it a day?

I think that's the crux of this PR's principal commit 327ca18.

Copy link
Collaborator

@IanLee1521 IanLee1521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs a minor fix up of a conflict in setup.py

@jsf9k jsf9k merged commit a278e69 into cisagov:develop Apr 6, 2018
cisagovbot pushed a commit that referenced this pull request Dec 19, 2023
Update the version of the `crazy-max/ghaction-github-labeler` Action and add a dependabot ignore directive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants