Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct default user name in shell provisioner #114

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Correct default user name in shell provisioner #114

merged 1 commit into from
Aug 23, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Aug 23, 2024

🗣 Description

This pull request corrects the default user name used in the final shell provisioner. This PR is an add-on to #113.

💭 Motivation and context

The final shell provisioner is intended to delete the default user, but with the incorrect user name that doesn't happen.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added bug This issue or pull request addresses broken functionality packer Pull requests that update Packer code labels Aug 23, 2024
@jsf9k jsf9k self-assigned this Aug 23, 2024
@jsf9k jsf9k requested review from dav3r, mcdonnnj and a team August 23, 2024 15:19
@jsf9k jsf9k mentioned this pull request Aug 23, 2024
Merged
10 tasks
dav3r
dav3r approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@jsf9k jsf9k enabled auto-merge August 23, 2024 15:34
@jsf9k jsf9k merged commit d294243 into develop Aug 23, 2024
9 of 10 checks passed
@jsf9k jsf9k deleted the improvement/switch-to-ubuntu-to-build-an-arm64-ami branch August 23, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@dav3r dav3r dav3r approved these changes

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

Labels
bug This issue or pull request addresses broken functionality packer Pull requests that update Packer code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @dv4harr10