-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add P&E database credentials, update dependencies, upgrade aws terraform provider #1428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing! nice work fixing the terraform 🙌🏽, I had no idea what was happening 😄
@epicfaace I added the conditional output for db-accessor so prod doesn't fail. Unfortunately, prevent_destroy doesn't have the functionality to actually ignore a resource replacement; just logs an error. |
We should be fine. We should just inspect the output of |
value = aws_instance.db_accessor[0].id | ||
} | ||
# output "db_accessor_instance_id" { | ||
# value = try(aws_instance.db_accessor[0].id, null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aloftus23 I think we should uncomment this out, could you do that in a separate PR?
Fixes:
Solution (update configurations to their own resources):
hashicorp/terraform-provider-aws#23125 (comment)
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-4-upgrade